Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove deprecated validThrough cube filters #1249

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

bprusinowski
Copy link
Collaborator

Closes #1195.

Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2023 2:58pm

@bprusinowski bprusinowski changed the title chore: Remove depreciated validThrough cube filters chore: Remove deprecated validThrough cube filters Nov 3, 2023
Copy link
Collaborator

@lloydrichards lloydrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I'm guessing there is some tests in E2E that are still testing this filter though?

@bprusinowski bprusinowski merged commit 4ee116a into main Nov 6, 2023
3 of 4 checks passed
@bprusinowski bprusinowski deleted the chore/remove-outdated-valid-through branch November 6, 2023 07:54
@bprusinowski
Copy link
Collaborator Author

I think not, at least we don't explicitly have validThrough anywhere in the app now, except in RDF typings. As this filter was essentially the same as noExpires, it shouldn't affect the tests 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

phase out deprecated schema:validThrough FILTER
2 participants